search

llealloo / audiolink

Audio reactive prefabs for VRChat
Other
354 stars 40 forks source link

Controller changes #203

Closed float3 closed 1 year ago

float3 commented 1 year ago

not sure if GetSettings() should be called before or after the init values are set at

https://github.com/llealloo/vrc-udon-audio-link/pull/203/commits/34892654d7a17b68b4d7a0a2ee87609e947776a7#diff-e1e6d098d6acaa81cb7a1bca4d1557ba2440957d141d52be056090618984161aR99

float3 commented 1 year ago

not sure if GetSettings() should be called before or after the init values are set at

3489265#diff-e1e6d098d6acaa81cb7a1bca4d1557ba2440957d141d52be056090618984161aR99

we decided that it should happen before

pema99 commented 1 year ago

Assuming you've tested that the changes to the controller work as intended, this looks good to me. Thanks for fixing the linking up button