llealloo / audiolink

Audio reactive prefabs for VRChat
Other
354 stars 40 forks source link

use cached PropertyID everywhere + Refactor #206

Closed float3 closed 1 year ago

pema99 commented 1 year ago

lmk if you plan to revisit this. currently cursed

float3 commented 1 year ago

I'm gonna run benchmarks this weekend

float3 commented 1 year ago

on my machine 1000 property sets by name take about 4.5 milliseconds 1000 property sets by id take about 1.7 milliseconds while 1000 PropertyToID method calls take about 4.1 milliseconds (these would happen only on Start())