search

llealloo / audiolink

Audio reactive prefabs for VRChat
Other
364 stars 40 forks source link

MenuItem #231

Closed float3 closed 1 year ago

float3 commented 1 year ago

Do not merge this before #230 goes through

pema99 commented 1 year ago

We should maybe consider folding this into AudioLinkImportFix.cs, potentially changing the name while doing so, just to keep this kind of stuff in one place. AudioLinkImportFix is currently a bit of a frankenstein of scene-and-package-management-things, which I actually think is fine, the name just isn't great.

(Just keep in mind if you move anything that the AUDIOLINK_STANDALONE define only works in that one file currently, added by our CI)

float3 commented 1 year ago

We should maybe consider folding this into AudioLinkImportFix.cs, potentially changing the name while doing so, just to keep this kind of stuff in one place. AudioLinkImportFix is currently a bit of a frankenstein of scene-and-package-management-things, which I actually think is fine, the name just isn't great.

(Just keep in mind if you move anything that the AUDIOLINK_STANDALONE define only works in that one file currently, added by our CI)

okay

float3 commented 1 year ago

@pema99 is this what you had in mind. I figured I would combine all three of these files since they are all pretty self contained