Closed float3 closed 1 year ago
This pr is really difficult to grok because you are doing so many different things and your commit messages aren't very indicate of the changes.
As far as I can tell, you are doing at least all of the following:
and probably more I didn't find
IMO mixing the 2 first points with the rest is a cardinal sin, since it makes the diff way more cursed than it has to be. I don't want to be a dick here, but could you please at least split this into:
refactoring (rename, dead code, reformat, style changes, etc.), bugfixes/usability (warnings, small behavior changes), readback changes (async readback + improves to readback UI, new texture format)
You could cherry pick stuff over, but looking at the history added in this PR, it's not very useful anyways, so a simple way to do this splitting is to just soft reset to branch start (git reset --soft <commit_before_first>
) and then re-commit the local changes relevant to each of the orthogonal goals
I can help you do this if you want
Retarget this to master. Dev is kill.