search

llealloo / audiolink

Audio reactive prefabs for VRChat
Other
364 stars 40 forks source link

improve yt dlp player #255

Closed float3 closed 1 year ago

float3 commented 1 year ago

continuation of #253

pema99 commented 1 year ago

It's a little wack that the diff is basically useless here because we renamed the file simultaneously with changing a bunch of code. Do you plan to address that or nah?

float3 commented 1 year ago

It's a little wack that the diff is basically useless here because we renamed the file simultaneously with changing a bunch of code. Do you plan to address that or nah?

what do you suggest?

pema99 commented 1 year ago

I think if you rename the file back to its original name, git might understand the diff. Worth a try, you can always change it in a later commit

pema99 commented 1 year ago

So long as you have minimal changes in the file, git is made to understand when you are just renaming stuff, and it will keep the history