search

llealloo / audiolink

Audio reactive prefabs for VRChat
Other
347 stars 38 forks source link

Implement Media State API #261

Closed fundale closed 11 months ago

fundale commented 1 year ago

Used for sending Video / Audio Player state to Avatar / World props Has Player Volume, Player Time, Player Playback state, Player loop / playlist state

float3 commented 1 year ago

Hi, thanks for the PR, just fyi we increment the version number on each release and we decided the next release will be 1.0.0 as we're switching to semver. also on release we copy the latest version changelog from changelog.md to the readme.md, until then we don't usually touch the changelog in readme.md

float3 commented 1 year ago

currently I'm keeping track of changes on the changelog branch, but I realize that's suboptimal so I'll try to merge that soon. other than that I think the feature you implemented is fine, we will have to test and get back to you with any change requests

pema99 commented 1 year ago

Thanks. The changes look mostly fine, but all the stuff relating to changing the version number should be removed, for the reasons @float3 points out

float3 commented 1 year ago

@fundale this pr is set so maintainers can edit your branch, I'm gonna assume this is intentional and will make the adjustments we need to merge it this weekend

fundale commented 1 year ago

Thanks. The changes look mostly fine, but all the stuff relating to changing the version number should be removed, for the reasons @float3 points out

Assuming Maintainers can discard those changes right? Or do I have to revert them?

techanon commented 1 year ago

With the removal of the /10, don't forget to update the docs/comments to reflect that change.

float3 commented 1 year ago

Thanks. The changes look mostly fine, but all the stuff relating to changing the version number should be removed, for the reasons @float3 points out

Assuming Maintainers can discard those changes right? Or do I have to revert them?

I'll change it

float3 commented 11 months ago

@fundale I'm getting

error: Authentication error: Authentication required: You must have push access to verify locks
error: failed to push some refs to 'https://github.com/fundale/vrc-udon-audio-link.git'

for some reason I can't push to your fork

here are the changes we require in a patch: https://gist.github.com/float3/cd364f25cd3f71cce010a94fd4863bee