search

llealloo / audiolink

Audio reactive prefabs for VRChat
Other
364 stars 40 forks source link

Doesnt account for high FPS #263

Open Happyrobot33 opened 1 year ago

Happyrobot33 commented 1 year ago

Describe the bug in detail: Audiolink doesnt account for high FPS, leading to things like 4 band data becoming more rapid with the higher FPS you have

Provide steps/code to reproduce the bug: Enable and disable VSync in the unity editor while looking at a 4 band visual

Expected behavior: Audiolinks FPS should be capped no matter the systems FPS

https://github.com/llealloo/vrc-udon-audio-link/assets/32679887/a71b3966-0d21-4d3d-ba10-fa7823939aed

pema99 commented 1 year ago

This is probably caused by the CRT having it's update rate set to 0 == go as fast as possible

pema99 commented 1 year ago

Hmm, actually it seems to be accounted for via unity_DeltaTime... strange

Happyrobot33 commented 1 year ago

to be clear, this occurs on 2019 aswell

pema99 commented 1 year ago

I discussed this a bit with Charles, and he seems convinced it isn't quite trivial to fix. We are leaving it for next release, when him and I have more time

float3 commented 4 months ago

@pema99 did we address this?

pema99 commented 4 months ago

No

pema99 commented 4 months ago

I tried but I couldn't figure it out