search

llealloo / audiolink

Audio reactive prefabs for VRChat
Other
364 stars 40 forks source link

Fix theme mode & colors being overwritten by defaults #282

Closed Saberpeep closed 1 year ago

Saberpeep commented 1 year ago

This modification ensures that the theme mode and colors are retrieved from the AudioLink instance at Start. Currently in master and release 0.3.2 they seem to get overridden by the default values at runtime. This fix was originally developed on release 0.3.2, though I ported it to master for the purposes of this pull req. I tested again using master and the included sample project/scene. I am not an expert with U# so feel free to suggest changes. I fixed this in my own local files and figured I might as well try to make a pull req to make it official.

Issue repo steps:

  1. Add audiolink and controller to your scene.
  2. Change theme colors and/or mode in the inspector.
  3. Either build and test or enter play mode with ClientSim.
  4. Observe that the mode dropdown has been set back to ColorChord, and the theme colors have reverted to the default yellow, blue, red, green.

With this fix the theme colors and mode will retain the values set before entering play mode.

Fixes #281

pema99 commented 1 year ago

Hey. Thanks for the PR. Gonna hold off on merging this for a bit since we are currently working on replacing the controller, and the changes are going to conflict.

pema99 commented 1 year ago

Fixed here https://github.com/llealloo/vrc-udon-audio-link/commit/d16349dca4c387c03a624f206c63ac9d23b8e333