llealloo / audiolink

Audio reactive prefabs for VRChat
Other
346 stars 38 forks source link

Unity 2022 SPS-I error in AudioLinkControllerLogo #293

Closed AtryFox closed 7 months ago

AtryFox commented 7 months ago

Describe the bug in detail: Unity 2022 seems to have changed some things about SPS-I, causing the SPS-I support in AudioLinkControllerLogo to break.

Provide steps/code to reproduce the bug: Build a world with AudioLink 1.2.0 in Unity 2022.3.6f/SDK3.5.0 casues a shader error in STEREO_INSTANCING_ON pass.

Expected behavior: No shader error should occur, SPS-I should be implemented properly.

Additional Information:

Shader error in 'AudioLink/Internal/AudioLinkControllerLogo': invalid subscript 'instanceID' at line 49 (on d3d11)
Shader error in 'AudioLink/Internal/AudioLinkControllerLogo': 'UnitySetupInstanceID': no matching 1 parameter function at line 49 (on d3d11)

Compiling Subshader: 0, Pass: , Vertex program with STEREO_INSTANCING_ON
Platform defines: SHADER_API_DESKTOP UNITY_ENABLE_DETAIL_NORMALMAP UNITY_ENABLE_REFLECTION_BUFFERS UNITY_LIGHTMAP_FULL_HDR UNITY_LIGHT_PROBE_PROXY_VOLUME UNITY_PBS_USE_BRDF1 UNITY_SPECCUBE_BLENDING UNITY_SPECCUBE_BOX_PROJECTION UNITY_USE_DITHER_MASK_FOR_ALPHABLENDED_SHADOWS
Disabled keywords: SHADER_API_GLES30 UNITY_ASTC_NORMALMAP_ENCODING UNITY_COLORSPACE_GAMMA UNITY_FRAMEBUFFER_FETCH_AVAILABLE UNITY_HALF_PRECISION_FRAGMENT_SHADER_REGISTERS UNITY_HARDWARE_TIER1 UNITY_HARDWARE_TIER2 UNITY_HARDWARE_TIER3 UNITY_LIGHTMAP_DLDR_ENCODING UNITY_LIGHTMAP_RGBM_ENCODING UNITY_METAL_SHADOWS_USE_POINT_FILTERING UNITY_NO_DXT5nm UNITY_NO_FULL_STANDARD_SHADER UNITY_NO_SCREENSPACE_SHADOWS UNITY_PBS_USE_BRDF2 UNITY_PBS_USE_BRDF3 UNITY_PRETRANSFORM_TO_DISPLAY_ORIENTATION UNITY_UNIFIED_SHADER_PRECISION_MODEL UNITY_VIRTUAL_TEXTURING
pema99 commented 7 months ago

Should be fixed in next release: https://github.com/llealloo/vrc-udon-audio-link/commit/33e8180dbf8be4913d7bdfa146005d8a905e6318