llealloo / audiolink

Audio reactive prefabs for VRChat
Other
364 stars 40 forks source link

Malformed `package.json` files #316

Closed foxscore closed 2 months ago

foxscore commented 2 months ago

Describe the bug in detail: The package.json files in the release zips are missing the required fields author.name and author.email. These fields are required as per the specification and exclusion of these fields may lead to issues with software that expects it. Especially since this is a "curated" package.

Provide steps/code to reproduce the bug: N/A

Expected behavior: The author.name and author.email fields should be present in all past and future versions.

Additional Information: N/A

float3 commented 2 months ago

thanks for the report, will address this, out of curiosity is there anything that breaks because this is missing?

float3 commented 2 months ago

note that in upm, at least:

 Author of the package.

This object contains one required field (name) and two optional fields (email) and (url).

For example: { "name" : "John Doe", "email" : "john.doe@example.com", "url" : "http://john.doe.example.com/" }

email may not be required in vpm either

but we should add an email regardless, only need to figure out which maintainers email

pema99 commented 2 months ago

Author isn't required by UPM at all. This is purely a VPM requirement. I don't think they rely on it anywhere, but the docs do state this, so it's a fair ask. The only fields required by UPM are package name and version

pema99 commented 2 months ago

If @llealloo is ok with it, we will use her info. Otherwise, mine