fix: build-script for ubuntu 16.04 and fedora 30

llebout / electron

:electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS - PPC64LE FORK

https://electronjs.org

MIT License

6 stars 6 forks source link

fix: build-script for ubuntu 16.04 and fedora 30 #3

Closed amitsadaphule closed 4 years ago

amitsadaphule commented 4 years ago

Description of Change

Fixes the build for Fedora 30 and Ubuntu 16.04 (https://github.com/leo-lb/electron/issues/1).

Checklist

[x] PR description included and stakeholders cc'd
[ ] npm test passes
[ ] tests are changed or added
[x] PR title follows semantic commit guidelines

Release Notes

Notes: no-notes

amitsadaphule commented 4 years ago

The PR https://github.com/leo-lb/chromium_power/pull/3 along with the new commit a66b40b3afcaff3f261300c66759e43f41216c7d incorporates all the review comments.

llebout commented 4 years ago

@amitsadaphule Merged! As commented on the PR;

You will also need to update the submodule in this electron fork, by doing "git pull" when in the chromium_power subdirectory, committing and pushing.

It's the "patches" directory