llelectronics / videoPlayer

Video player for sailfish os
27 stars 19 forks source link

No update Yt-Dl feedback, app stays in update state infinitely #28

Closed Pohli closed 5 years ago

Pohli commented 5 years ago

Today I tapped on Update Youtube-Dl in Settings for the first time. The background got darkened and moved back to main page. In foreground is a never-ending throbber. App was still responsive although darkened, is this intended? I had to close app and start again. There should be some message about what has gone wrong or any other kind of feedback.

Jolla Phone with SFOS 3.0.0.8 and LLs Video Player 1.9

llelectronics commented 5 years ago

It should inform you after the update performed well or if it fails.

Pohli commented 5 years ago

Tested again, after more than 20 min I cancelled. Console output doesn't say anything about update procedure.

Edit: deleted unnecessary output

llelectronics commented 5 years ago

That is correct. You won't see any output in the terminal. Is the youtube-dl binary (python file) available in ~/.local/share/harbour-videoPlayer/harbour-videoPlayer/ and is it marked executable (it should)

Pohli commented 5 years ago
[nemo@Sailfish ~]$ ls -l .local/share/harbour-videoPlayer/harbour-videoPlayer/
 total 1668
drwxrwxrwx 1 nemo nemo      28 2018-10-27 04:23 QML
-rwxrwxrwx 1 nemo nemo 1706857 2018-11-28 11:41 youtube-dl
llelectronics commented 5 years ago

Then it should update just fine if your internet connection is working. It might be that the youtube-dl app itself hangs if you have no internet connection which causes the progress loop not to end as it is waiting for an exit code of the app itself.

Pohli commented 5 years ago

I rebooted my phone and tried again but still same problem. My WiFi connection is fine, I'm posting from the same phone right now.

llelectronics commented 5 years ago

What happens when you manually try updating calling the youtube-dl binary with the -U option?

Pohli commented 5 years ago

Please have a look if I did something wrong:

[nemo@Sailfish ~]$ cd .local/share/harbour-videoPlayer/harbour-videoPlayer/
[nemo@Sailfish harbour-videoPlayer]$ ls
QML  youtube-dl
[nemo@Sailfish harbour-videoPlayer]$ youtube-dl --help
bash: youtube-dl: command not found
[nemo@Sailfish harbour-videoPlayer]$ ./youtube-dl --help
/usr/bin/env: python: No such file or directory
[nemo@Sailfish harbour-videoPlayer]$ ./youtube-dl -U
/usr/bin/env: python: No such file or directory
llelectronics commented 5 years ago

So the issue is that you are missing python. Weird. It is a dependency of LLs Video Player. Just manually install python with devel-su pkcon install python

Pohli commented 5 years ago

Thanks, now update worked. But I get this Ressource Error (spelling is wrong, should be Resource) with every YouTube video so far. Do I need to be logged in?

llelectronics commented 5 years ago

Try non DRM videos. That should play fine. Otherwise you can find the ytdl option in the pulley menu of the video to try the (including DRM) video grabbing with youtube-dl

P.S.: I am closing this here as the issue has been solved.

llelectronics commented 5 years ago

This has been further improved with this commit: https://github.com/llelectronics/videoPlayer/commit/0dbd22024f29be5654ddd14210f4fe6603f7bc6f