llelectronics / webcat

WebCat is a Webkit based webbrowser for sailfish os
19 stars 13 forks source link

Add some sentence if possible to translate #47

Closed ghost closed 7 years ago

ghost commented 7 years ago

This sentences is only showed if webcat not have internet. It is good to add these strings to have a full complete translation. captura_20170729_001

llelectronics commented 7 years ago

Those error messages are produced by the webkit engine itself. I cannot translate them from within webcat.

ghost commented 7 years ago

Ok what do we do with this issue? Close it or keep it Open?

llelectronics commented 7 years ago

Keep it open for now. As you see I tagged it upstream-issue and wontfix for now. On my first research there might be the possibility for custom error message implementation by reimplementing the html errorcode detection and assign translatable error messages to it. This is however a little bit of work.

ghost commented 7 years ago

OK thank you very much.

ghost commented 7 years ago

There are more here. " Title of the bookmark " " URL of bookmark " captura_20170731_001 = )

ghost commented 7 years ago

" Choose user agent " captura_20170731_003 " Choose Search engine " captura_20170731_004 " Engine URL use % for searchterm " " Custom " captura_20170731_005

llelectronics commented 7 years ago

Thanks again for reporting. Fixed those new mentions in this commit: https://github.com/llelectronics/webcat/commit/cbae0c3aa27f77e1fa4aa9642454fc452856b4f6

ghost commented 7 years ago

Ok , almost done! one string are missing to translate " Custom " on last picture(show above) " Custom - Agent of user "

llelectronics commented 7 years ago

Thanks for notifying fixed aswell with https://github.com/llelectronics/webcat/commit/865b1728ed7969b21d75aaed95616e6fa59f6d66

ghost commented 7 years ago
ghost commented 7 years ago

" Play " captura_20170805_001

ghost commented 7 years ago

" Download " captura_20170805_002

llelectronics commented 7 years ago

Thanks updated here: https://github.com/llelectronics/webcat/commit/e2f3a101577f14d466a8d0e77f6d1a2ca40da31d

ghost commented 7 years ago

the thanks are for you.