llelectronics / webcat

WebCat is a Webkit based webbrowser for sailfish os
19 stars 13 forks source link

Some sentences need optimization #52

Closed ghost closed 7 years ago

ghost commented 7 years ago
llelectronics commented 7 years ago

Ah ok. Maybe the subheader silica element is not the best to use here for those long descriptions.

ghost commented 7 years ago

Still the text is not correctly seen, what do you think? I think it should be better to delete this text and pass it to the text below. It would look more clean. captura_20170804_001

llelectronics commented 7 years ago

It looks fine to me. That's exactly what the patch does. Adding a second line for the section header.

ghost commented 7 years ago

Well ,it is look better then before. But the first letter of the sentence does not start glued to the left side, so it looks like a bad layout, that's my opinion, but the developer is you and you are the owner on any layout you wanna look. I'm just doing and observing possible errors about the Browser in general. My suggestion: is that passing these sentences for the sentences below, would look more clean and optimized. ??

llelectronics commented 7 years ago

I am using the default section silica element here and they have the text alignment set to right instead of left. I could change that though in general those should be only short section headers nothing more. Putting them in the the description does not make sense to me. I will allign them to the left and then we'll see.

ghost commented 7 years ago

Sound good! thank.

llelectronics commented 7 years ago

Done here https://github.com/llelectronics/webcat/commit/6d8f64977d2b9559390354d49709e57bc0173b19

ghost commented 7 years ago

First i will send a PR with all the translation,then i build webcat again to see how looking.

llelectronics commented 7 years ago

It does not look ideal for those long translations in the section header. Though I have no other idea what to use instead.

ghost commented 7 years ago

ok . i apologize for my late respond, i was without internet for 48 hours

ghost commented 7 years ago

Looking much better captura_20170807_001

ghost commented 7 years ago

??