llfbandit / app_links

Android App Links, Deep Links, iOs Universal Links and Custom URL schemes handler for Flutter.
https://pub.dev/packages/app_links
Apache License 2.0
224 stars 81 forks source link

Plugin conflicts with share-to-app on Android #103

Closed emersion closed 8 months ago

emersion commented 8 months ago

Describe the bug

When using this plugin with share_handler: this plugin handles the share-to-app intents instead of leaving it up to the other plugin.

Manifest:

            <intent-filter>
                <action android:name="android.intent.action.VIEW"/>
                <category android:name="android.intent.category.DEFAULT"/>
                <category android:name="android.intent.category.BROWSABLE"/>
                <data android:scheme="irc"/>
                <data android:scheme="ircs"/>
            </intent-filter>
            <intent-filter>
                <action android:name="android.intent.action.SEND"/>
                <category android:name="android.intent.category.DEFAULT"/>
                <data android:mimeType="*/*"/>
            </intent-filter>

When opening irc:// links, app_links handles the VIEW intent properly.

When sharing an image to my app, app_links handles the SEND intent, but shouldn't. The SEND intent should be left for the share_handler plugin to handle.

Does it related to

[x] App Links (Android)
[ ] Deep Links (Android)
[ ] Universal Links (iOS)
[ ] or Custom URL schemes? (iOS)

Does the example project work?

[ ] Yes
[ ] No
[x] Irrelevant here

Did you fully read the instructions for the targeted platform before submitting this issue?

[x] Yes
[ ] No
[ ] Irrelevant here

llfbandit commented 8 months ago

Thanks for the report. I agree with this change, this package has no aim to handle sharing feature. This basic support was originally added because there was no other package to handle this on Android platform.

llfbandit commented 8 months ago

Done in cc6aea93

emersion commented 8 months ago

Thank you very much!