search

llfbandit / app_links

Android App Links, Deep Links, iOs Universal Links and Custom URL schemes handler for Flutter.
https://pub.dev/packages/app_links
Apache License 2.0
221 stars 81 forks source link

fix(iOS): Return true in NSUserActivityTypeBrowsingWeb to indicate that app links handled the activity #111

Closed AlexHodges13 closed 7 months ago

AlexHodges13 commented 8 months ago

fixes #96

AlexHodges13 commented 7 months ago

@llfbandit could you please review/merge this PR at your earliest convenience? Thanks in advance!

AlexHodges13 commented 7 months ago

@llfbandit Could you please review/merge this PR or grant me privileges to do so? This is an open defect in my production app that I need to get resolved!

llfbandit commented 7 months ago

Closing this to provide a breaking change notice. v5 will be released soon. Thanks for your contribution.

intervall-mohammed commented 2 months ago

Can we please get this merged in anyway? I've had to apply this change to fix an issue with our app where pressing on a link would (correctly) open the app, and then immediately also open the same link in Safari.

(the app_links version was 6.2.1, and there don't seem to have been any iOS-related changes to app_links since then)

We aren't using go_router for the record, so this isn't the same as the original issue.

llfbandit commented 2 months ago

No, the package provides now everything you need to handle it by yourself. Read the docs.