llfbandit / app_links

Android App Links, Deep Links, iOs Universal Links and Custom URL schemes handler for Flutter.
https://pub.dev/packages/app_links
Apache License 2.0
221 stars 81 forks source link

Deep links always open in app and system browser using Flutter 3.24.3 #158

Closed noforeignland closed 2 months ago

noforeignland commented 2 months ago

Describe the bug

After upgrading to Flutter 3.24.2 deep links on iOS open in both my app and the system browser.

Observed behaviour: Click on universal link opens the app. Quickly after that the native browser is opened with the link as target.

In my logs I see a warning "Failed to handle route information in Flutter.".

The warning points my to this Flutter PR which was recently merged and is part of 3.24.2: https://github.com/flutter/engine/pull/52643

See line 1885 of FlutterViewController where the warning is issued. My guess is that app_link does not return a success code here and that the framework passes the link on to the system browser to open instead.

Does it related to

[X] Universal Links (iOS)

Does the example project work?

[X] Irrelevant here

Did you fully read the instructions for the targeted platform before submitting this issue?

[X] Yes

Uploaded your files to webserver, HTTPS, direct connection, scheme pattern setup, ...

[X] Yes

llfbandit commented 2 months ago

Duplicates #156. Please refer to Android & iOS docs to disable Flutter deeplinking.

noforeignland commented 2 months ago

Duplicates #156. Please refer to Android & iOS docs to disable Flutter deeplinking.

Thanks for the quick response, that fixed it.

I hadn't understood the documentation and wondered why I would ever want to disable deep links when trying to get deep links working. Can I suggest rephrasing this line in the docs:

with

Thanks again. I appreaciate the work you put into this!

llfbandit commented 2 months ago

Sure please fill a PR