search

llfbandit / app_links

Android App Links, Deep Links, iOs Universal Links and Custom URL schemes handler for Flutter.
https://pub.dev/packages/app_links
Apache License 2.0
176 stars 68 forks source link

getInitialAppLink() allways return null on windows #27

Closed UnluckyY1 closed 1 year ago

UnluckyY1 commented 1 year ago

So Far everything works fine on Android and iOS but when it comes to windows when you lunch the app from URL Scheme the getInitialAppLink() is Always return null .

to summarise it's the same issue like #7 but for windows platform Edit : even with the example app if you start the app from an url scheme getInitialAppLink will always return null on windows platform

brennschlus commented 1 year ago

@UnluckyY1 I've slighty changed code to make this work in this MR https://github.com/llfbandit/app_links/pull/31, if you want to test it just write me, I can show how to make it work

UnluckyY1 commented 1 year ago

@brennschlus I will do some tests and let you know if it works update: unfortunately it still doesn't work 😓

brennschlus commented 1 year ago

This is probably because here https://github.com/llfbandit/app_links/blob/master/app_links/pubspec.yaml app_links_windows imports from pub.dev, to make it work you need to download localy my branch import library locally in this file app_links_windows: path: path/to/app_links_windows by the way, I found this library https://pub.dev/packages/protocol_handler what are working out of the box, it does pretty similar job

UnluckyY1 commented 1 year ago

oh you're right i will try again with the necessary changes and let you know

UnluckyY1 commented 1 year ago

@brennschlus after fixing app_links_windows dependency, i can confirm that getInitialAppLink() now works @llfbandit can you check his PR when you got time Thank you guys

llfbandit commented 1 year ago

Thanks @brennschlus for the fix. I will trust you on this one. I'm overloaded since... a while now. Sorry for that. Merged and published!