search

llfbandit / app_links

Android App Links, Deep Links, iOs Universal Links and Custom URL schemes handler for Flutter.
https://pub.dev/packages/app_links
Apache License 2.0
176 stars 68 forks source link

Android 12 Firebase dynamic link was not well handled #29

Closed AdrienAudouard closed 1 year ago

AdrienAudouard commented 1 year ago

This PR fixe the issue #26

The deeplink created by firebase was not well handled for Android 12 and above.

A firebase deeplink is composed by a short link (who should be received by the app) and a link (this link is used when the user do not have the app installed on his device). Before Android 12 the short link was send to the app but from Android 12 and above the link was send to the app, so it break the deeplink behavior on some apps. This PR fix this and always send the correct link.

AdrienAudouard commented 1 year ago

Hey, thanks for your response. So, I removed all the code related to the data reading and I've added the org.microg:safe-parcel dependancy which is doing the same job (my code was roughly inspired by this lib).

llfbandit commented 1 year ago

Hey, thanks for your response. So, I removed all the code related to the data reading and I've added the org.microg:safe-parcel dependancy which is doing the same job (my code was roughly inspired by this lib).

I know :) You code was fine without the dependancy but it's ok like this too. Unused code should be trimmed at build time.

AdrienAudouard commented 1 year ago

I'm not really fan of copying the code of another lib but if you prefer I can rollback this change !