search

llfbandit / app_links

Android App Links, Deep Links, iOs Universal Links and Custom URL schemes handler for Flutter.
https://pub.dev/packages/app_links
Apache License 2.0
176 stars 68 forks source link

feat: support deeplink on Linux platform #76

Closed LucasXu0 closed 7 months ago

LucasXu0 commented 9 months ago

For more details, please refer to this issue.

llfbandit commented 9 months ago

Many thanks to bring linux support to this package. Seems good to me.

Could you update the README.md by adding a howto setup on this platform?

LucasXu0 commented 9 months ago

Could you update the README.md by adding a howto setup on this platform?

Sure. Will update this PR asap.

TekExplorer commented 8 months ago

Hey, are you still working on this?

If it works and all thats needed is minor documentation changes then shouldnt we just get it done and merged soon?

liquidiert commented 7 months ago

@LucasXu0 would also really love to see this in the app_links package!

LucasXu0 commented 7 months ago

I've updated the documentation. Apologies for the long wait.

Screenshot 2023-11-09 at 17 26 11
TekExplorer commented 7 months ago

Out of curiosity, what is the purpose of that

- TRUE
+ FALSE
TekExplorer commented 7 months ago

Also consider using ```patch instead of ```xml for formatting

LucasXu0 commented 7 months ago

Out of curiosity, what is the purpose of that

- TRUE
+ FALSE

Return FALSE to allow the package to handle the command line.

TekExplorer commented 7 months ago

Return FALSE to allow the package to handle the command line.

Ah, but will we still be able to handle command line args normally if we wanted to?

LucasXu0 commented 7 months ago

What do you mean "handle command line args normally"?

On Fri, Nov 10, 2023 at 11:05 AM Omar Kamel @.***> wrote:

Return FALSE to allow the package to handle the command line.

Ah, but will we still be able to handle command line args normally if we wanted to?

— Reply to this email directly, view it on GitHub https://github.com/llfbandit/app_links/pull/76#issuecomment-1805004087, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC2QIL5JM7W7ACJRF5HCWNDYDWKYBAVCNFSM6AAAAAA47NABLCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBVGAYDIMBYG4 . You are receiving this because you were mentioned.Message ID: @.***>

llfbandit commented 7 months ago

I guess he wanted to know if modifying the return result or just applying the plugin would conflict with other command line processing. But you already answered to this in your previous comment. The purpose of the modifications is about getting all command line parameters (well the first, in our case).

TekExplorer commented 7 months ago

But you already answered to this in your previous comment.

...no?

What do you mean "handle command line args normally"?

I mean, if i currently parse command line parameters ie, myApp --login username:password will this interfere with that? And if it does, is there a method to get around it?

LucasXu0 commented 7 months ago

But you already answered to this in your previous comment.

...no?

What do you mean "handle command line args normally"?

I mean, if i currently parse command line parameters ie, myApp --login username:password will this interfere with that? And if it does, is there a method to get around it?

I'm not sure. I suggest you can give it a try by checking out this PR.

liquidiert commented 7 months ago

@LucasXu0 @llfbandit @TekExplorer I just tried with @LucasXu0s branch and command line args can still be parsed after setting line 88 to FALSE 👍