search

llfbandit / app_links

Android App Links, Deep Links, iOs Universal Links and Custom URL schemes handler for Flutter.
https://pub.dev/packages/app_links
Apache License 2.0
176 stars 68 forks source link

Typo in docs? #91

Closed AndreiMisiukevich closed 5 months ago

AndreiMisiukevich commented 5 months ago

Describe the bug

image

Does it related to

[ ] App Links (Android)
[ ] Deep Links (Android)
[X] Universal Links (iOS)
[ ] or Custom URL schemes? (iOS)

Does the example project work?

[ ] Yes
[ ] No
[X] Irrelevant here

Did you fully read the instructions for the targeted platform before submitting this issue?

Uploaded your files to webserver, HTTPS, direct connection, scheme pattern setup, ...

[ ] Yes
[ ] No
[X] Irrelevant here

llfbandit commented 5 months ago

No this is to illustrate when true can't be returned from the delegate, you can still handle link manually with handleLink method.

animeshjain commented 5 months ago

This was very confusing to read. Can the documentation be worded better? After reading your comment, is it correct that the following AppDelegate file will work and no change needs to be made:

import Flutter

@UIApplicationMain
@objc class AppDelegate: FlutterAppDelegate {
  override func application(
    _ application: UIApplication,
    didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?
  ) -> Bool {
    GeneratedPluginRegistrant.register(with: self)
    return super.application(application, didFinishLaunchingWithOptions: launchOptions)
  }
}