search

llfbandit / record

Audio recorder from microphone to a given file path. No external dependencies, MediaRecorder is used for Android an AVAudioRecorder for iOS.
https://pub.dev/packages/record
243 stars 204 forks source link

fix(macos): correct incorrect PCM16 Audio Stream data #336 #337

Closed ihdream72 closed 5 months ago

ihdream72 commented 5 months ago

Incorrect buffer size for sending Streams and increasing the size

ihdream72 commented 5 months ago

This is my first PR on Github. Not sure if I did it right -_-

llfbandit commented 5 months ago

This is fine. Can you confirm that iOS platform also works with this change?

ihdream72 commented 5 months ago

I don't have an IOS phone, so I couldn't check it on IOS. If you look at the record_darwin source, it is split between macos and ios and I only modified the code for macos. I don't think it will affect IOS.

ihdream72 commented 5 months ago

I got an iphone and tested it out and it worked fine. The way I tested was the same, I got the stream record with PCM16 and connected it to Google STT and it worked fine.