Handle large user list - Githubissues

llimllib / limbo

A simple, clean, easy to modify Slack chatbot

MIT License

402 stars 160 forks source link

Handle large user list #127

Closed llimllib closed 6 years ago

llimllib commented 6 years ago

With a very large team, the series of calls to load up the user list can run up against slack's rate limiting. So:

up the limit from 25 to 250
log if we hit the rate limit and return the objs we loaded so far
- it's better to have a partial members list and be running than to die (I think?)
sleep for a second between calls. There should be no more than a few at 250 per call
bump version to 6.0.1

llimllib commented 6 years ago

@topher200 I'm just going to ram this one through because 6.0.0 failed immediately on my work slack... that's what I get for not testing against a big org

topher200 commented 6 years ago

I see no obvious issues 👍