search

llimllib / limbo

A simple, clean, easy to modify Slack chatbot
MIT License
402 stars 160 forks source link

Fix tests that break under `make test-network` #131

Open topher200 opened 6 years ago

topher200 commented 6 years ago

123 adds the command make test-network. These tests break under this new command:

122 fixes the stockphoto test, marking that as done

topher200 commented 6 years ago

133 fixes these tests:

Checking them off the list

topher200 commented 6 years ago

@llimllib The weather plugin is difficult to test due to the API key requirement. Any ideas on how we can handle that one?

StewPoll commented 6 years ago

I forget what test system limbo uses, but could you set it to look for an environment variable to get the API key, and if not set skip it?

On Sat, 14 Oct. 2017, 7:57 am Topher Brown, notifications@github.com wrote:

@llimllib https://github.com/llimllib The weather plugin is difficult to test due to the API key requirement. Any ideas on how we can handle that one?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/llimllib/limbo/issues/131#issuecomment-336577320, or mute the thread https://github.com/notifications/unsubscribe-auth/AGk_7Y6Nmy5dsdzyEZbTmK0AxCC6VwhYks5sr9zUgaJpZM4P3-K4 .

llimllib commented 6 years ago

to test the API, you'll need an API key; but this is one place where it gets a bit weird, because you're basically at this point testing the weather API. Anyway, my advice is to get an API key and set it in the environment in which make test-network runs.

llimllib commented 6 years ago

@StewPoll do you want a contributor bit too? Anything you want to work on?

Also if either of you want an invite to the slack instance I use for testing, send me an email at bill@billmill.org (I need an email address to invite you)