search

llimllib / limbo

A simple, clean, easy to modify Slack chatbot
MIT License
402 stars 160 forks source link

add `make test-network` command #132

Closed topher200 closed 6 years ago

topher200 commented 6 years ago

Normally, when tests are run we use vcr fixtures for any external API requests that our test calls make. This is great! It lets us run our tests quickly and deterministically, without worrying about the slowness or availablity of external services.

However, this means our tests can't alert us to external APIs changing. If an API changes, our vcr fixtures would continue to provide us with old API data, giving us false-positives that our plugins were working.

make test-network lets us run the same tests but ignores the vcr fixtures. This means that tests will hit the external network. It uses an environment variable, set by the Makefile, to alert our test utils whether or not to use vcr for a given run.

Closes #123

topher200 commented 6 years ago

I'm still learning github's PR tool. It seems like if I want to do two requests (one which depends on the other), the GH way to do it is to make it one monolithic pull request with individual commits. I'll close this and upload a different PR with both commits.