search

llimllib / limbo

A simple, clean, easy to modify Slack chatbot
MIT License
403 stars 160 forks source link

limbo handles slackbot reminders twice #156

Open llimllib opened 6 years ago

llimllib commented 6 years ago
  1. Set a reminder for !image cute dog
  2. wait for the reminder to post
  3. note that limbo does not respond
eSoares commented 6 years ago

To me, it's working. But has a slightly different bug: it replies when I setup the reminder.

image

llimllib commented 6 years ago

haha, doh! I guess my test wasn't accurate enough

eSoares commented 6 years ago

I think the fix is to force commands to be on the start of the line, that would make them not trigger when someone says something like:" just use !image command "

For the slackbot, maybe pre-process the incoming message to parse and remove the "Reminder: " and add a flag isReminder in the event json. That way would not break any plugins and solve the issue.

llimllib commented 6 years ago

I bet that there's something in the slackbot message packet that we could cue off of, to know that a reminder is being set as opposed to being triggered

StewPoll commented 6 years ago

Isn't it set to ignore slack it?

On Sat, 24 Mar. 2018, 01:28 Bill Mill, notifications@github.com wrote:

haha, doh! I guess my test wasn't accurate enough

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/llimllib/limbo/issues/156#issuecomment-375702839, or mute the thread https://github.com/notifications/unsubscribe-auth/AGk_7fUTnT2rZFUsdmDoC-bUNhkuORFZks5thRSOgaJpZM4S45gV .

eSoares commented 6 years ago

In the current implementation looks like it: https://github.com/llimllib/limbo/blob/master/limbo/limbo.py#L146

I'm running an older version on my bot, but I don't see a reason to filter out slackbot messages...