Fix regex for image / gif scraping.

llimllib commented 4 years ago

Thanks! Will review

fenwar commented 4 years ago

I should've run the tests, sorry. This fails but I guess the test fixture needs updating to match the new format of the image search results. IDK if I have time to figure out the fixture format just yet! :(

On Mon, 17 Feb 2020 at 16:30, Bill Mill notifications@github.com wrote:

Thanks! Will review

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/llimllib/limbo/pull/178?email_source=notifications&email_token=AAOPIFWZJ6YZU2SB27QQIXDRDK3RHA5CNFSM4KWU3ZZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEL7ALSY#issuecomment-587072971, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOPIFVGE4X3HR3FF7BP3BLRDK3RHANCNFSM4KWU3ZZQ .

llimllib commented 4 years ago

np, I will try to fix that

llimllib commented 4 years ago

FTR, the process was:

rm test/fixtures/image_* test/fixtures/gif_* the make test (pytest generates the updated fixtures automatically)
insert a print statement in gif.py and image.py to print all the possible images/gifs
insert that list into the test case

(Not saying you should have known how to do this! Just leaving it in case it's useful someday... to myself maybe)

Thanks for the contribution!

llimllib commented 4 years ago

released 7.1.0 with the updated plugins

llimllib / limbo

Fix regex for image / gif scraping. #178