search

llkhacquan / blackrose

Project in Software engineering class
1 stars 1 forks source link

Review code of another team #31

Open llkhacquan opened 11 years ago

llkhacquan commented 11 years ago

@FabioNgo @huangoc93

llkhacquan commented 11 years ago

missing comments Missing comments

llkhacquan commented 11 years ago

class name Class name should begin with capital letter.

huangoc93 commented 11 years ago

wifilocator test src com example wifilocatordemo test testpassactest java at master sonnm56 wifilocator github

Missing a lot of comments.

huangoc93 commented 11 years ago

wifilocator test src com example wifilocatordemo test wifidatabasetest java at master sonnm56 wifilocator github Bad class name: it should be WiFiDatabaseTest and missing comments

huangoc93 commented 11 years ago

wifilocator test src com example wifilocatordemo test wifiusingdatabasetest java at master sonnm56 wifilocator github Unused method (or missing comments ?)

huangoc93 commented 11 years ago

wifilocator test src com example wifilocatordemo test wifiinfomattiontest java at master sonnm56 wifilocator github Bad class name/file name and missing comments

FabioNgo commented 11 years ago

1 Comment on the picture :v:

FabioNgo commented 11 years ago

2 In class Functions

sonnm56 commented 11 years ago

thank a lot. We will fix them