add an option to skip beatmap files that cause an exception

llllllllll / slider

Utilities for working with osu! files and data

https://llllllllll.github.io/slider/index.html

GNU Lesser General Public License v3.0

39 stars 17 forks source link

add an option to skip beatmap files that cause an exception #88

Closed joseph-ireland closed 3 years ago

joseph-ireland commented 3 years ago

…, which allows creating a library using beatmap dumps from data.ppy.sh

tybug commented 3 years ago

out of curiosity, why do some osu files in the dump error / what do they throw?

joseph-ireland commented 3 years ago

Here's a log for the latest dump: library_log.txt

tybug commented 3 years ago

thanks - the dump seems to conveniently double as a stress test for slider. We've seen a few of these before:

OverflowError: Python int too large to convert to C int is #83
ValueError: cannot convert float NaN to integer is #84

(these may in fact be caused by the same underlying issue; I haven't investigated). The rest are new.

joseph-ireland commented 3 years ago

I think a lot of them are files that break the spec but just happen to parse in osu. There's one that has no new line after [TimingPoints], there's a load which have floating point values where there should be an integer, and a few that are invalid UTF-8.

tybug commented 3 years ago

as an aside, since you've made a few PRs to this repo, I'll mention that the standard convention for naming git branches is with dashes instead of underscores: allow-library-parse-errors.