llllllllll / slider

Utilities for working with osu! files and data
https://llllllllll.github.io/slider/index.html
GNU Lesser General Public License v3.0
39 stars 16 forks source link

update star rating #95

Open Arlind-dev opened 3 years ago

Arlind-dev commented 3 years ago

the star rating is still outdated, could you update it?

tybug commented 3 years ago

I’d rather not have to keep our sr and pp calc constantly up to date, so I’m thinking of using pyttanko for them instead. Our current methods would remain as a thin wrapper around pyttanko with no breaking changes from a consumer standpoint.

@llllllllll I’m curious if there’s any particular reason you chose to roll your own pp and sr calc instead of using an existing library?

llllllllll commented 3 years ago

The reason I wrote it myself was so that I could do it in a vectorized way, instead of throwing away all the intermediate calculations for each run, you can pass vectors of hit counts and get a vector of results, which is useful for sampling to create score distributions.