Closed auphofBSF closed 4 years ago
Thank you for taking the time to report this issue, @auphofBSF . I am not using Jack on Windows, so not sure what the issue can be. Is it possible that you are having this reported issue with jack on Windows and Supercolllider: https://github.com/jackaudio/jack2/issues/380?
Would it be possible to try to uninstall jack and see if that works?
Thanks again, Luis
Thank you @llloret for that relevant flaged issue. Just to Note Supercollider is working fine. I am using it with Foxdot and so is SonicPi, all with or/and with out a running portaudio and Jackd (ver1.9.13). I have however not been using Supercollider through Jackd, I will try this and I will try and setup on another relatively clean machine SonicPi, vscode and your Extension with out jack.
Whilst that jackd issue may have a part to play, I am noting that on a second attempt to run the extension, scsynth.exe is spawned and so is erl.exe, there is a valid log file for each in this.sonicPiHomePath() + "/.sonic-pi/logs
When running Sonic Pi (app) it logs in this.sonicPiHomePath() + "/.sonic-pi/logs/server-output,log"
. I have used this as comparison
When running the extension in the console output log it show that scsynth and erl are running, but the osmid bridge does not get started - no o2m or m2o, should I be seeing these ?
So I'm thinking something is failing in the Sonic Pi Server Runtime startup spawned by startRubyServer()
, it does not appear to be scsynth, any clues ?
Seems like the server booting needs some more work to be completely stable. We'll look into it.
@auphofBSF, can you try something?
If you have the latest official version 3.2.0, go to where you have installed sonic-pi and then open the file .../app/server/ruby/lib/sonic-pi/util.rb and change lines 594 AND 601 from
Process.wait pid
to
Process.wait(pid, Process::WNOHANG)
Make a backup copy of the file first! If you have another Sonic Pi version, the line numbers may not match... in that case, look for the functions register_process and kill_and_deregister_process and make the change.
In my local installation I have seen that with the original version, sometimes it fails to boot, where with the WNOHANG, it boots properly every time. I am not sure why it works as is with the original editor, but perhaps timing is involved....
Let me know if that works.
In fact, looking at this, it is already like that in Sonic Pi's master branch...
Success!! that worked Process.wait(pid, Process::WNOHANG)
.
I Installed sonicpi from https://sonic-pi.net/files/releases/v3.2.2/sonic-pi-for-win-x64-v3.2.2.msi . This obviously is slightly behind the repo.
I have not looked into the logistics of building sonicpi from the repo. Possibly a note in this extensions requirements on how to install /build from the latest repo. Thanks for responding to this issue so fast with a positive outcome , good luck with this extension,
Sonicpis ide is good but having a more comprehensive IDE to drive sonicpi is great. I know @samaaron philosophy of keeping a simple and good experience to first time users certainly works and is admirably executed. However for those that want to take this further having an extension to a solid IDE will bring in people from the top and move people from the bottom further. I put SonicPi aside because I could not use my shortcuts for commenting and decided to use Foxdot under Atom instead. This extension is the gamechanger! Now I will have to look deeper.
Look forward to seeing how this extension evolves and if some or all of the elements of sonicpi's IDE can be incorporated.
Great to know that this fixed the problem for you.
And thank you for your feedback. It is very encouraging to know that this effort might make some people come back to Sonic Pi or might bring some new ones.
I have already added some fx snippets from Sonic Pi, and planning to add more snippets and other things very soon. Stay tuned :).
I am sorry this extension is failing to work for me. SonicPi is installed fresh and is working correctly. the extension appears to launch somewhat correctly, recognises the ruby file but does not appear do anything when I press alt R. I am also considering that the startup of scsynth is not complete. What I find odd is that I have to have jackd running if I fail to have this running see the additional error log below. this is not required when I run the Sonicpi IDE app. For a test I am just using
play 70
as the ruby script. Look forward to getting your extension working thank you. Happy to assist in any further debugging if you can point me to where to look !Platform: windows 10.0.18363 Build 18363 Extension Sonic-pi-vscode-editor: commit: 7d0f522
The following are the logs and developer tool console session images at
1) Initial Extension Execution (F5)
log(extension host)
2) after
test1.rb
is loaded and alt-R is attemptedi have also attempted to run from command palette; SonicPi: Run
Log output: [Extension Development Host]
Console - [extension development host]
3) Error when JackD is not running