lllyasviel / Fooocus

Focus on prompting and generating
GNU General Public License v3.0
38.4k stars 5.13k forks source link

InPaint feather Falloff feature #1788

Open RodTDai opened 6 months ago

RodTDai commented 6 months ago

Hey guys, please add a "feather" control for inPainting masks, it is very important because 90% of time inPainting on realistic persons photos do not transition smoothly enough. I tried to upload a custom mask with a blured mask, but it does not work, it clips the gradient and just use a dull mask.

Thanks

mashb1t commented 6 months ago

Do you mean a fade/fizzle in functionality to make inpainting not 100% hard on the edges? Might relate to https://github.com/lllyasviel/Fooocus/issues/1443

poor7 commented 6 months ago

Also I didn't find the "erase" (correction) tool there.

RodTDai commented 6 months ago

I don´t think it is related. anyway, feather mask feature is very important. I recall of having this on automatic1111 ages ago when i used. Doing additional "photoshop" just to blend better a dull mask with the original image is not a really good approach. So a mask feather parameter should be super useful. Thanks guys.

thiner commented 6 months ago

看不懂你的描述。。。看你的名字应该是懂中文的(姓戴?),你可以用中文描述你的需求,或者截个图说明什么是“feather mask”。

RodTDai commented 6 months ago

在Photoshop中,蒙版羽化是指模糊蒙版的边缘,创建蒙版区域和非蒙版区域之间的平滑过渡。

On Tue, 9 Jan 2024, 10:45 Sebastian.W, @.***> wrote:

看不懂你的描述。。。看你的名字应该是懂中文的(姓戴?),你可以用中文描述你的需求,或者截个图说明什么是“feather mask”。

— Reply to this email directly, view it on GitHub https://github.com/lllyasviel/Fooocus/issues/1788#issuecomment-1882834889, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZWHL7SRVMTIYYHWIFBXQR3YNUNT5AVCNFSM6AAAAABBQPJT6WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBSHAZTIOBYHE . You are receiving this because you authored the thread.Message ID: @.***>

thiner commented 6 months ago

Maybe this option? image

mashb1t commented 6 months ago

Reference to https://github.com/lllyasviel/Fooocus/issues/1848#issue-2073564033 by @lanyusan:

the new image generated with Fooocus with the mask would have sharp edge. I am wondering if there is any chance Fooocus could be enhanced to add inpainting edge softening or other techniques to address the problem.

RodTDai commented 6 months ago

Maybe this option? image

No, that is not mask blur/feathering It refers to the softening of edges in a selection or mask, which creates a transition zone where the effect or adjustment blends gradually into the surrounding area. This is particularly useful for avoiding harsh, noticeable edges and achieving a more natural, integrated look

This is feather on a mask image

RodTDai commented 6 months ago

I'm attempting to grasp the situation in this thread. As of now, we lack a mask feather feature, and it's not the "ControNet softness" that thiner mentioned. The absence of this feature is a significant drawback. Even if the model is unable to process gradient masks, a viable workaround could involve blending the original image with the inpainted area, utilizing a gradient soft mask in post-processing. It's essential to introduce a feather pixel size parameter in the UI to adjust the softening extent of the mask. Thanks guys

RodTDai commented 6 months ago

I'm attempting to grasp the situation in this thread. As of now, we lack a mask feather feature, and it's not the "ControNet softness" that thiner mentioned. The absence of this feature is a significant drawback. Even if the model is unable to process gradient masks, a viable workaround could involve blending the original image with the inpainted area, utilizing a gradient soft mask in post-processing. It's essential to introduce a feather pixel size parameter in the UI to adjust the softening extent of the mask. Thanks guys I'm attempting to grasp the situation in this thread. As of now, we lack a mask feather feature, and it's not the "ControNet softness" that thiner mentioned. The absence of this feature is a significant drawback. Even if the model is unable to process gradient masks, a viable workaround could involve blending the original image with the inpainted area, utilizing a gradient soft mask in post-processing. It's essential to introduce a feather pixel size parameter in the UI to adjust the softening extent of the mask. Thanks guys

mashb1t commented 4 months ago

https://www.reddit.com/r/StableDiffusion/comments/1ankbwe/a1111_dev_a1111_forge_have_a_new_feature_called/

from https://github.com/lllyasviel/Fooocus/issues/2363#issue-2154914336