lllyasviel / Fooocus

Focus on prompting and generating
GNU General Public License v3.0
40.56k stars 5.66k forks source link

[Feature Request]: Support for DORA and other types of LORAs #3192

Open santiagosfx opened 3 months ago

santiagosfx commented 3 months ago

Is there an existing issue for this?

What would your feature do?

Compatibility with DORAs and other types of LORAs to generate images. Fooocus simply cannot detect a Dora. You can load it, but it will not be reflected in the image generation. It will not influence it.

Proposed workflow

Work as usual

Additional information

Dora is basically a potential successor to Lora, or a variant. I'll leave more information about it in the commentary, and some Dora models from Civitai as examples. https://www.reddit.com/r/StableDiffusion/comments/1asxk3u/dora_weightdecomposed_lowrank_adaptation/ https://sebastianraschka.com/blog/2024/lora-dora.html

Sample civitai lora model: https://civitai.com/models/483185/takagi-san-karakai-jouzu-no-takagi-san

mashb1t commented 3 months ago

Please provide more details about what your expectation is with this feature and what does / does not work. The description can e.g. be enriched with references to papers or models.

santiagosfx commented 3 months ago

According to the tests I have done, Foocus simply does not detect the Doras. I tried with a concept, and a drawing style, and it failed to be detected. It generated images, but it was as if the dora was not there. Even if I had loaded it and used the trigger word. As far as I know, Dora is basically a potential successor to Lora, or a variant. I'll leave more information about it in the commentary, and some Dora models from Civitai as examples. https://www.reddit.com/r/StableDiffusion/comments/1asxk3u/dora_weightdecomposed_lowrank_adaptation/ https://sebastianraschka.com/blog/2024/lora-dora.html

Sample civitai lora model: https://civitai.com/models/483185/takagi-san-karakai-jouzu-no-takagi-san

mashb1t commented 3 months ago

Thanks for elaborating. DoRA support is also included in https://github.com/lllyasviel/Fooocus/pull/3084 (more specific: here), but sadly i need some extra time and/or support here. Any help is welcome!

raochinmay6 commented 3 months ago

sorry for the comment here but can you add an image to video generation feature in fooocus like cumfyui , it would be so nice, I personally like fooocus so much because of its easy webui interface, but comfyui is a little bit complex for me ... can it will be happen in future ?

mashb1t commented 3 months ago

@raochinmay6 this is off-topic, but Fooocus does not and will not have video generation capabilities as it's an image AI tool only. There are already tools out there who specialize in video generation.