search

lllyasviel / stable-diffusion-webui-forge

GNU Affero General Public License v3.0
8.72k stars 865 forks source link

LDSR upscaler not showing #1335

Open Melyns opened 3 months ago

Melyns commented 3 months ago

Hi. I have the latest version of forge ui & i have the LDSR extension enabled, & yet im unable to select it in the upscaler drop down because it's not showing up.

I tried manually downloading the model & the project.yaml file & i put them in \stable-diffusion-webui-forge\models\LDSR without any luck. In a1111 it works just fine.

Any solution to this please?

maraan666 commented 2 months ago

I have the same problem.

NeiroNext commented 2 months ago

Same problem, waiting for a fix

NeiroNext commented 2 months ago

Found the problem, this malicious commit is to blame: https://github.com/lllyasviel/stable-diffusion-webui-forge/commit/bccf9fb23a2cbc9d42091a856b3d35b2c4414d51

NeiroNext commented 2 months ago

It's the last correct commit with LDSR: https://github.com/lllyasviel/stable-diffusion-webui-forge/commit/aafe11b14c0d859d0d3845862864d0380b9ea5ef. If you need LSDR you can return to old version by command: git checkout aafe11b14c0d859d0d3845862864d0380b9ea5ef

Melyns commented 2 months ago

well done. i cant even imagine how you found it. this software is getting scary to manage, there seem to be a lot of bugs lost under walls of code

Musigreg commented 2 months ago

It's the last correct commit with LDSR: aafe11b. If you need LSDR you can return to old version by command: git checkout aafe11b14c0d859d0d3845862864d0380b9ea5ef

Will that not revert to the version without flux ?

Musigreg commented 2 months ago

It's the last correct commit with LDSR: aafe11b. If you need LSDR you can return to old version by command: git checkout aafe11b14c0d859d0d3845862864d0380b9ea5ef

Also, where do I input this ?

I just get :

E:\SDForge>git checkout aafe11b14c0d859d0d3845862864d0380b9ea5ef fatal: not a git repository (or any of the parent directories): .git

NeiroNext commented 2 months ago

It's the last correct commit with LDSR: aafe11b. If you need LSDR you can return to old version by command: git checkout aafe11b14c0d859d0d3845862864d0380b9ea5ef

Will that not revert to the version without flux ?

I can't check now, but I see all the changes found in flux after this edit, so yes, most likely this will remove its support, or at least greatly reduce it 😔

NeiroNext commented 2 months ago

It's the last correct commit with LDSR: aafe11b. If you need LSDR you can return to old version by command: git checkout aafe11b14c0d859d0d3845862864d0380b9ea5ef

Also, where do I input this ?

I just get :

E:\SDForge>git checkout aafe11b fatal: not a git repository (or any of the parent directories): .git

You need to go inside webui folder. If you suddenly want to return it back, just run git checkout master

ryankhart commented 2 months ago

Do we know why it was removed yet? I did a quick browse through the issues, and it seems that a lot of issues were related to LDSR. Maybe the maintainer got fed up with troubleshooting for it and decided to remove it entirely because of it?

Musigreg commented 2 months ago

Why not let it be there without removing it, even if no maintenance? It was amazing with faceswap, and now we have to settle for less...

Melyns commented 2 months ago

Why not let it be there without removing it, even if no maintenance? It was amazing with faceswap, and now we have to settle for less...

sadly that what happened to the hashing function as well. So many people were wondering why civitai isnt detecting their model anymore including me https://github.com/lllyasviel/stable-diffusion-webui-forge/pull/1529#issuecomment-2311183305