search

lllyasviel / stable-diffusion-webui-forge

GNU Affero General Public License v3.0
7.38k stars 715 forks source link

banding artifacts in hires fix #1633

Open Korner83 opened 2 weeks ago

Korner83 commented 2 weeks ago

Using hires makes vertical/horizontal banding artifects. I have tested with different hires upscalers some are less noticable, but it is visible depending on the image. Also it is more prominent if we use higher multiplier in hires. My example (on her face, click on full res to see): kép

You can read more about this issue here: https://www.reddit.com/r/StableDiffusion/comments/1eyrljx/what_am_i_doing_that_is_causing_the_banding/

I'm not sure about the Tiled Diffusion possible solution though.

lllyasviel commented 2 weeks ago
  1. Flux does not really work with "Latent" upscale
  2. you need to give what model you are using. some quants do not work well with img2img
  3. I just tested fp8 and common esr hrfix and it works in 100% cases without artifacts
l0stl0rd commented 2 weeks ago

I find that NF4 has a tendency to so some banding even without High res fix.

Korner83 commented 2 weeks ago
  1. Flux does not really work with "Latent" upscale
  2. you need to give what model you are using. some quants do not work well with img2img
  3. I just tested fp8 and common esr hrfix and it works in 100% cases without artifacts

I have tested fp8 version with esr high res fix and it was also visible. It also depends on the image and it is not always prominent.

Vagrin commented 1 week ago

I get the same banding upscaling 1.75 in i2i .35 denoise. So it's Flux itself giving me the banding. I'm running with Flux1-Dev-Q8_0.gguf. But I've been getting it with the other versions. I'm just expecting that's part of Flux for now.

foureyednymph commented 4 days ago

damn are there really no fixes to this?? it's driving me insane

Vagrin commented 4 days ago

damn are there really no fixes to this?? it's driving me insane

I may have bad news for you. I think it's built into Flux itself. Try generating a 2000+ pixel image with Flux itself. No hires fix, no upscale... banding. That's what my testing has revealed.

Korner83 commented 1 hour ago

  1. Flux does not really work with "Latent" upscale

    1. you need to give what model you are using. some quants do not work well with img2img

    2. I just tested fp8 and common esr hrfix and it works in 100% cases without artifacts

Any chance to look into it and solve this issue?:

Related topics: https://github.com/lllyasviel/stable-diffusion-webui-forge/issues/1712 https://github.com/lllyasviel/stable-diffusion-webui-forge/issues/1821