lllyasviel / stable-diffusion-webui-forge

GNU Affero General Public License v3.0
8.71k stars 864 forks source link

Color Picker tool not picking correct RGB color. (When using HDR) #1719

Open YakuzaSuske opened 2 months ago

YakuzaSuske commented 2 months ago

When doing inpainting sketch or anything that uses the color picker tool, the color picker shows a much brighter image on the preview pixels than the actual colors of the image. The RGB values of the image when i select the color never match up with the actual color below the picker tool. image

Haoming02 commented 2 months ago

tehe :P

YakuzaSuske commented 2 months ago

@Haoming02 You misunderstood... I'm trying to pick the orange color on the image... It's giving me a yellow color. Not orange.

Haoming02 commented 2 months ago

Oh oops XD

Then yeah, that's strange.

YakuzaSuske commented 2 months ago

Oh oops XD

Then yeah, that's strange.

Yhea i found the issue. For some reason it has to do with the fact if you are using an HDR display with the HDR setting turned on. If HDR is turned on, it makes the preview super bright and it changes the color of the image for when the color picker goes to pick the color. But when i turn the HDR of my display off or like on the windows HDR settings, it fixes it. It seems to be something to do with how the images are handled. I'm not sure if there is a fix for this or even know how to begin to fix it tbh.

With HDR turned on: image

With HDR turned off: image