lllyasviel / stable-diffusion-webui-forge

GNU Affero General Public License v3.0
8.04k stars 787 forks source link

lora support for one trainer loras #1727

Closed DarkViewAI closed 2 weeks ago

DarkViewAI commented 1 month ago

would love to use loras from one trainer on here

monotected commented 1 month ago

same , missed keys ..... 2 days ago try to add keys in lora.py *(like in comfui latest build) but nothing

lllyasviel commented 1 month ago

do you have example lora

DarkViewAI commented 1 month ago

do you have example lora

Here is one, this one is trained with T5 and Clip L

https://huggingface.co/Maxivi/sda/tree/main

DarkViewAI commented 1 month ago

@lllyasviel in comfyui it works fine.

https://github.com/comfyanonymous/ComfyUI/commit/d043997d30d91ab057f770d3396c2e288e37b38a

this is what they did

DarkViewAI commented 1 month ago

@lllyasviel i also added in a smaller version

DarkViewAI commented 1 month ago
xz

it also seems comfy hasnt fixed the te2/t5 keys being loaded in

DarkViewAI commented 1 month ago

opened issue with them as well - https://github.com/comfyanonymous/ComfyUI/issues/4837

lllyasviel commented 1 month ago

update and try again

monotected commented 1 month ago

everything works for me )) ,Tnx ! *(only low lora strength about~ 0.5 for Dev )

DarkViewAI commented 1 month ago

update and try again

works now thank you!

DarkViewAI commented 1 month ago

@lllyasviel seems this update broke kohya loras now

DarkViewAI commented 1 month ago

@lllyasviel https://github.com/lllyasviel/stable-diffusion-webui-forge/issues/1747