[Bug]: Repeated Upscaler Entries

Haoming02 commented 6 months ago

Checklist

[X] The issue exists after disabling all extensions
[X] The issue exists on a clean installation of webui
[ ] The issue is caused by an extension, but I believe it is caused by a bug in the webui
[X] The issue exists in the current version of the webui
[X] The issue has not been reported before recently
[ ] The issue has been reported before but has not been fixed yet

What happened?

In the Extras tab, the upscalers in the ESRGAN folder now show up twice in the dropdown.

Steps to reproduce the problem

Pull the latest commit (43c9e3b)
Launch the Webui
Go to Extras tab
Click on the Upscalers dropdown

What should have happened?

Each file only shows up once

What browsers do you use to access the UI ?

Microsoft Edge

Sysinfo

N/A

Console logs

N/A

Additional information

N/A

jipsita commented 6 months ago

I have the same problem, any workaround? it's just aesthetically annoying but still :/

catboxanon commented 6 months ago

I can't reproduce this as it doesn't occur for me with a fresh install.

catboxanon commented 6 months ago

This seems to be coming from upstream, but as I mentioned above this isn't something I'm able to reproduce on a clean install after adding a few models to the ESRGAN folder.

Haoming02 commented 6 months ago

Right now, my Forge installation uses a symlink for the entire models folder, instead of using the set A1111_HOME thingy in the .bat. Maybe this is the cause?

I added a print(file) at this line, and I got:

C:\Users\Michael.C\Documents\GitHub\stable-diffusion-webui\models\ESRGAN\2x-AnimeClassics-UltraLite.pth
C:\Users\Michael.C\Documents\GitHub\stable-diffusion-webui\models\ESRGAN\4x-UltraSharp.pth
C:\Users\Michael.C\Documents\GitHub\stable-diffusion-webui\models\ESRGAN\4xLSDIRplusC.pth
C:\Users\Michael.C\Documents\GitHub\stable-diffusion-webui-forge\models\ESRGAN\2x-AnimeClassics-UltraLite.pth
C:\Users\Michael.C\Documents\GitHub\stable-diffusion-webui-forge\models\ESRGAN\4x-UltraSharp.pth
C:\Users\Michael.C\Documents\GitHub\stable-diffusion-webui-forge\models\ESRGAN\4xLSDIRplusC.pth

Meaning, it somehow loads the files twice.

Funnily, I also put another model here:

C:\Users\Michael.C\Documents\GitHub\stable-diffusion-webui-forge\models\DAT\4xNomos8kDAT.pth

But this one doesn't show up twice.

catboxanon commented 6 months ago

Thanks! I'm able to reproduce now after symlinking the entire models folder as you mentioned.

catboxanon commented 6 months ago

https://github.com/AUTOMATIC1111/stable-diffusion-webui/pull/15035 will close this, and likely some other issues as well such as https://github.com/lllyasviel/stable-diffusion-webui-forge/issues/282.

lllyasviel / stable-diffusion-webui-forge