[Bug]: Soft Inpainting does not fully disable

vonespy commented 3 months ago

Checklist

[ ] The issue exists after disabling all extensions
[ ] The issue exists on a clean installation of webui
[ ] The issue is caused by an extension, but I believe it is caused by a bug in the webui
[X] The issue exists in the current version of the webui
[ ] The issue has not been reported before recently
[ ] The issue has been reported before but has not been fixed yet

What happened?

I did some experimenting with soft inpainting yesterday. Today even though I have soft inpainting turned off, I'm seeing ghosts of what was in the picture before in the hard inpainting areas, which never happened before I enabled and disabled soft inpainting.

The ghosts are eliminated if i grossly exaggerate the inpainting, which makes me further suspect that there's something in the soft inpainting code that's not being fully turned off.

Steps to reproduce the problem

Enable soft inpainting
Disable soft inpainting
Inpaint image
Output shows ghost images of what was in the inpainted area in outside areas of inpainting (those closes to the inpaint border)

What should have happened?

Now that soft inpainting is disabled, I shouldn't be seeing any artifacts from the hard inpainting areas. These artifacts appear to be applied at the very end of the render, as I don't see them at all in the preview images, only in the finished product.

What browsers do you use to access the UI ?

Mozilla Firefox, Google Chrome, Microsoft Edge

Sysinfo

sysinfo-2024-03-13-20-38.json

Console logs

Is there a way to enable logging in the forge startup flags?

Additional information

No recent changes except for enabling soft inpainting, then disabling it today.

vonespy commented 3 months ago

Note: I fully restarted my workstation multiple times after turning off soft inpainting.

catboxanon commented 3 months ago

FYI, soft inpainting doesn't work correctly with Forge at all currently. https://github.com/lllyasviel/stable-diffusion-webui-forge/pull/494

vonespy commented 3 months ago

FYI, soft inpainting doesn't work correctly with Forge at all currently. #494

That would explain why my experiments with soft inpainting went so badly. I couldn't find any settings that actually did anything useful. The issue is that it still seems to be creating ghosts of what was behind the inpaint mask no matter what I do, so once you turn it on, some pieces appear to be on for good, unfortunately.

Thanks for the reply!

VantomPayne commented 3 months ago

Is there an ETA on a fix on this, I use soft inpainting quite frequently and it would seem to be a major downside if it was meant to be a spotlight feature for 1.8.0 on the upstream.

monstari commented 1 month ago

Any news on this? Very frustrating.

lllyasviel / stable-diffusion-webui-forge