llm-tools / embedJs

A NodeJS RAG framework to easily work with LLMs and embeddings
https://llm-tools.mintlify.app/get-started/introduction
Apache License 2.0
331 stars 41 forks source link

docs: fix PDF data source link in Overview #169

Closed jhony112 closed 2 days ago

jhony112 commented 3 days ago

DataSources Pdf link currently points to a wrong url, this fixes the href reference

Description

Old url on overview page for DataSources points to components/data-sources/pdf-file should be : components/data-sources/pdf

Fixes # (issue)

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Checklist:

adhityan commented 2 days ago

Thank you for the fix.

nx-cloud[bot] commented 2 days ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 90288dc112ccf6aaf2ea27f0ad2c863c4422924b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target - [`nx run-many --t=build`](https://cloud.nx.app/runs/k80VYWRxU3?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.

adhityan commented 2 days ago

The project follows conventional commit standards. Could you amend your commit messages to follow this pattern? Read more here - https://www.conventionalcommits.org/en/v1.0.0

I think in your case, you need to remove the space between the : and docs. Sorry to have this enforced but all the other build tools work with this standard.

jhony112 commented 2 days ago

@adhityan should be fixed now

adhityan commented 2 days ago

Great. LGTM.