search

llm-tools / embedJs

A NodeJS RAG framework to easily work with LLMs and embeddings
https://llm-tools.mintlify.app/get-started/introduction
Apache License 2.0
335 stars 40 forks source link

Added LocalEmbeddings, Ollama model and related examples with README updates #45

Closed markomanninen closed 6 months ago

adhityan commented 6 months ago

I have a few points to discuss on the custom API bit around the thought

Since the format of a custom API is implementation dependent, this should probably not be a part of the library itself. Everyone is free to add thier own implementation in their codebase as they need it. Maybe a documentation and example would suffice.

My ask - could you separate this into two PRs? One adding support for Ollama and the other for local embedings? We can get the Ollama part merged and the other bit can be added post more thought.

markomanninen commented 6 months ago

I was actually thinking two separate PR's at first, but then work went under same "local" usage case. Yes, I can split them.