search

lloeki / ex-mode

Ex mode for Atom
MIT License
169 stars 59 forks source link

Deprecated call to `atom.showSaveDialogSync` #223

Open sarangjo opened 6 years ago

sarangjo commented 6 years ago

In Atom 1.30.0, 

atom.showSaveDialogSync is deprecated and will be removed soon. Please, implement ::saveAs and ::getSaveDialogOptions instead for pane items or use Pane::saveItemAs for programmatic saving.

It would be good to update the codebase to change these calls!

chipschipschips commented 5 years ago

This is still an issue in Atom v1.38.0, ex-mode 0.18.0 (latest version).

atom.showSaveDialogSync is deprecated and will be removed soon. Please, implement ::saveAs and ::getSaveDialogOptions instead for pane items or use Pane::saveItemAs for programmatic saving.
AtomEnvironment.showSaveDialogSync - <embedded>:1:714236
Ex.write - /Users/chips/.atom/packages/ex-mode/lib/ex.coffee:348:25
Ex.w - /Users/chips/.atom/packages/ex-mode/lib/ex.coffee:373:19
<unknown> - /Users/chips/.atom/packages/ex-mode/lib/ex.coffee:3:59
Command.execute - /Users/chips/.atom/packages/ex-mode/lib/command.coffee:194:18
ExState.processOpStack - /Users/chips/.atom/packages/ex-mode/lib/ex-state.coffee:83:19
rhinesj commented 4 years ago

Any plans to update ex-mode to address it? Any tips to disable the code that causes the deprecation warning without breaking much?