search

lloeki / matterfront

Mattermost frontend app for OS X, Windows and Linux
MIT License
152 stars 27 forks source link

JavaScript error on manual reload #31

Closed kingfisher77 closed 8 years ago

kingfisher77 commented 8 years ago

With Mattermost 1.2 we receive this error message in a popup window. It happens after the first reload per cmd-r.

Is this propably related to Mattermost 1.2?

Uncaught Exception: Error: Attempting to call a function in a renderer window that has been closed or released. Function provided here: undefined. at ret (/Applications/matterfront.app/Contents/Resources/atom.asar/browser/lib/rpc-server.js:146:21) at MenuItem.click (/Applications/matterfront.app/Contents/Resources/atom.asar/browser/api/lib/menu-item.js:58:20) at Function.delegate.executeCommand (/Applications/matterfront.app/Contents/Resources/atom.asar/browser/api/lib/menu.js:127:69)

LongLiveCHIEF commented 8 years ago

I don't believe this would be related to the upgrade. Give me a bit to get on a real computer and I will come back and take another look at your error.

teetrinkers commented 8 years ago

I can reproduce this using Mattermost 1.2.0-rc1:

daemongh commented 8 years ago

I was able to track this down to the menu code and requiring the menu.js file in the app ready handler instead of loading it through the HTML seems to fix that problem.