search

lloeki / matterfront

Mattermost frontend app for OS X, Windows and Linux
MIT License
152 stars 27 forks source link

Build issue on Windows #66

Open aaronhagopian opened 8 years ago

aaronhagopian commented 8 years ago

When trying to build I am getting the following error:

Downloading electron-v$npm_package_electronVersion-linux-ia32.zip Error: GET https://github.com/atom/electron/releases/download/v$npm_package_electronVersion/electron-v$npm_package_electronVersion-linux-ia32.zip returned 404 [ [Error: GET https://github.com/atom/electron/releases/download/v$npm_package_electronVersion/electron-v$npm_package_electronVersion-linux-ia32.zip returned 404] ] undefined

seems like the $npm_package_electronVersion variable is not getting set correctly, ideas?

Thanks

LongLiveCHIEF commented 8 years ago

Something with windows doesn't consume these the correct way. We're working on it for the full 1.3 release.

geekytime commented 8 years ago

Yeah, I have the same issue. It seems to have something to do with how cmd.exe/git bash/npm work together to layer environment variables.

That giant command-line should probably be split out into a shell script anyway...

asadpiz commented 8 years ago

Ran into same issue, had to hardcode the $npm_package_electronVersion variable to "0.35.4" in package.json.

because of the value of variable: _"electronVersion": "0.35.4" _ in the same file.

markspolakovs commented 8 years ago

FYI, a workaround is to edit the package.json file and under scripts -> build change $npm_package_productName and $npm_package_electronVersion to %npm_package_productName% and %npm_package_electronVersion%.