search

lloesche / valheim-server-docker

Valheim dedicated gameserver with automatic update, World backup, BepInEx and ValheimPlus mod support
https://hub.docker.com/r/lloesche/valheim-server
Apache License 2.0
1.96k stars 276 forks source link

Add support for Valheim Plus Mod #63

Closed alec-hs closed 3 years ago

alec-hs commented 3 years ago

Adding support for Valheim Plus mod via an ENV Variable would be great. Stuff probably needed to make this work:

https://github.com/nxPublic/ValheimPlus

armanatz commented 3 years ago

@lloesche I am actually working on this as we speak. I will try to provide a PR for this as soon as I am done with it

kachunkachunk commented 3 years ago

Woo, glad to hear (and see this submitted)! I think the big gotcha in my view surrounds the supervisor bits and loading BePinEx, but I think it'd be a bunch of hours/days for me to figure out, if I can even get to that point.

nxPublic commented 3 years ago

Dawm you guys are great, thanks for taking the effort into it. ❤️

This is a great documentation and i will make sure to link it in the V+ repo as soon as its ready to.

Thank you!

armanatz commented 3 years ago

@lloesche PR submitted for this. Let me know what you think

wedol commented 3 years ago

See https://github.com/lloesche/valheim-server-docker/issues/72#issuecomment-783307733

lloesche commented 3 years ago

If you guys would like to test ValheimPlus support you can use the dev tag of the Docker image lloesche/valheim-server:dev

Updated README is here https://github.com/lloesche/valheim-server-docker/tree/dev

Let us know in https://github.com/lloesche/valheim-server-docker/pull/91 if everything works.

Thanks to all testers!

lloesche commented 3 years ago

@nxPublic I'd very much like your input on #91 I tried using the included start_game_bepinex.sh the issue however is that it has no process control meaning if I kill the script the server keeps on running. One way of solving this would be to exec the server and just not reset LD_LIBRARY_PATH. Or track the server process and trap SIGINT/SIGTERM and bubble them up to the server PID. Anyhow, I just took the contents and added them to the valheim-server start script.

NoobTaco commented 3 years ago

Testing now. One question, what about other mods? For example, the Craft from All Containers mod? If I drop the dll in the data/plus/plugins directory, will it be overwritten on update?

EDIT and UPDATE

It looks like it works! I dropped 3 additional mods into the folder, and everything works so far. It even created the config file in the same place as the v+ config.

I will do a longer play test to make sure nothing breaks and report back my findings.

Great work all!

lloesche commented 3 years ago

@NoobTaco it'll work however anything in the data directory is regenerated when updates happen. We could add something that allows to add additional mods. That's a separate issue though.

lloesche commented 3 years ago

ValheimPlus support has been merged into main