llogiq / bytecount

Counting occurrences of a given byte or UTF-8 characters in a slice of memory – fast
Apache License 2.0
225 stars 27 forks source link

Update edition from 2018 to 2021 #84

Closed roynrishingha closed 1 year ago

roynrishingha commented 1 year ago
roynrishingha commented 1 year ago

@llogiq can you review it?

llogiq commented 1 year ago

I need to test it locally. Our CI is currently totally borked.

llogiq commented 1 year ago

Sorry, but updating to edition 2021 would break our minimum-supported Rust version (msrv) policy.

The current minimum supported version is 1.32.0. I'll have to look if we need to update to a newer version to support neon intrinsics (which I plan on doing) or perhaps WASM (which might be added later), and if yes, we might make the jump if and only if that version also supports edition 2021.