llogiq / flame

An intrusive flamegraph profiling tool for rust.
Apache License 2.0
694 stars 30 forks source link

thread test is failing #30

Closed ignatenkobrain closed 6 years ago

ignatenkobrain commented 6 years ago

25 was closed, but workaround mentioned there didn't work...

+ /usr/bin/cargo test --release -j1
       Fresh serde v1.0.19
       Fresh num-traits v0.1.40
       Fresh dtoa v0.4.2
       Fresh lazy_static v0.2.9
       Fresh itoa v0.3.4
       Fresh unicode-xid v0.1.0
       Fresh libc v0.2.33
       Fresh quote v0.3.15
       Fresh serde_json v1.0.6
       Fresh synom v0.11.3
       Fresh thread-id v3.2.0
       Fresh syn v0.11.11
       Fresh serde_derive_internals v0.17.0
       Fresh serde_derive v1.0.19
   Compiling flame v0.2.0 (file:///builddir/build/BUILD/flame-0.2.0)
     Running `/usr/bin/rustc --crate-name flame src/lib.rs --emit=dep-info,link -C opt-level=3 --test --cfg 'feature="default"' --cfg 'feature="json"' --cfg 'feature="serde"' --cfg 'feature="serde_derive"' --cfg 'feature="serde_json"' -C metadata=55a8dd78fadf7079 -C extra-filename=-55a8dd78fadf7079 --out-dir /builddir/build/BUILD/flame-0.2.0/target/release/deps -L dependency=/builddir/build/BUILD/flame-0.2.0/target/release/deps --extern serde=/builddir/build/BUILD/flame-0.2.0/target/release/deps/libserde-9be79e3bf217c101.rlib --extern serde_json=/builddir/build/BUILD/flame-0.2.0/target/release/deps/libserde_json-c4e6d1533382957b.rlib --extern serde_derive=/builddir/build/BUILD/flame-0.2.0/target/release/deps/libserde_derive-b8e3961dc7f06b8e.so --extern lazy_static=/builddir/build/BUILD/flame-0.2.0/target/release/deps/liblazy_static-81a739ef1bc96bbc.rlib --extern thread_id=/builddir/build/BUILD/flame-0.2.0/target/release/deps/libthread_id-4879e83dca0b7ebf.rlib -Copt-level=3 -Cdebuginfo=2 -Clink-arg=-Wl,-z,relro,-z,now`
     Running `/usr/bin/rustc --crate-name demo examples/demo.rs --crate-type bin --emit=dep-info,link -C opt-level=3 --cfg 'feature="default"' --cfg 'feature="json"' --cfg 'feature="serde"' --cfg 'feature="serde_derive"' --cfg 'feature="serde_json"' -C metadata=1a0c0dff5daa6f29 -C extra-filename=-1a0c0dff5daa6f29 --out-dir /builddir/build/BUILD/flame-0.2.0/target/release/examples -L dependency=/builddir/build/BUILD/flame-0.2.0/target/release/deps --extern serde=/builddir/build/BUILD/flame-0.2.0/target/release/deps/libserde-9be79e3bf217c101.rlib --extern serde_json=/builddir/build/BUILD/flame-0.2.0/target/release/deps/libserde_json-c4e6d1533382957b.rlib --extern serde_derive=/builddir/build/BUILD/flame-0.2.0/target/release/deps/libserde_derive-b8e3961dc7f06b8e.so --extern lazy_static=/builddir/build/BUILD/flame-0.2.0/target/release/deps/liblazy_static-81a739ef1bc96bbc.rlib --extern thread_id=/builddir/build/BUILD/flame-0.2.0/target/release/deps/libthread_id-4879e83dca0b7ebf.rlib --extern flame=/builddir/build/BUILD/flame-0.2.0/target/release/deps/libflame-1016207c5c092409.rlib -Copt-level=3 -Cdebuginfo=2 -Clink-arg=-Wl,-z,relro,-z,now`
     Running `/usr/bin/rustc --crate-name tests tests/tests.rs --emit=dep-info,link -C opt-level=3 --test --cfg 'feature="default"' --cfg 'feature="json"' --cfg 'feature="serde"' --cfg 'feature="serde_derive"' --cfg 'feature="serde_json"' -C metadata=8b7dc1aeb3c717dd -C extra-filename=-8b7dc1aeb3c717dd --out-dir /builddir/build/BUILD/flame-0.2.0/target/release/deps -L dependency=/builddir/build/BUILD/flame-0.2.0/target/release/deps --extern serde=/builddir/build/BUILD/flame-0.2.0/target/release/deps/libserde-9be79e3bf217c101.rlib --extern serde_json=/builddir/build/BUILD/flame-0.2.0/target/release/deps/libserde_json-c4e6d1533382957b.rlib --extern serde_derive=/builddir/build/BUILD/flame-0.2.0/target/release/deps/libserde_derive-b8e3961dc7f06b8e.so --extern lazy_static=/builddir/build/BUILD/flame-0.2.0/target/release/deps/liblazy_static-81a739ef1bc96bbc.rlib --extern thread_id=/builddir/build/BUILD/flame-0.2.0/target/release/deps/libthread_id-4879e83dca0b7ebf.rlib --extern flame=/builddir/build/BUILD/flame-0.2.0/target/release/deps/libflame-1016207c5c092409.rlib -Copt-level=3 -Cdebuginfo=2 -Clink-arg=-Wl,-z,relro,-z,now`
    Finished release [optimized] target(s) in 5.23 secs
     Running `/builddir/build/BUILD/flame-0.2.0/target/release/deps/flame-55a8dd78fadf7079`
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out
     Running `/builddir/build/BUILD/flame-0.2.0/target/release/deps/tests-8b7dc1aeb3c717dd`
running 11 tests
test dropped_guarded_event ... ok
test double_nested ... ok
test cant_note ... ok
test implicit_guarded_event ... ok
test end_with ... ok
test named_guarded_event ... ok
test single_event ... ok
test single_nested ... ok
test multiple_guard_early_return ... ok
test wrong_name ... ok
test threads ... FAILED
failures:
---- threads stdout ----
    thread 'threads' panicked at 'assertion failed: `(left == right)`
  left: `2`,
 right: `6`', tests/tests.rs:111:4
failures:
    threads
test result: FAILED. 10 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out
ignatenkobrain commented 6 years ago
+ /usr/bin/cargo test --release -j1
       Fresh quote v0.3.15
       Fresh libc v0.2.33
       Fresh serde v1.0.19
       Fresh num-traits v0.1.40
       Fresh unicode-xid v0.1.0
       Fresh lazy_static v0.2.9
       Fresh dtoa v0.4.2
       Fresh itoa v0.3.4
       Fresh thread-id v3.2.0
       Fresh synom v0.11.3
       Fresh serde_json v1.0.6
       Fresh syn v0.11.11
       Fresh serde_derive_internals v0.17.0
       Fresh serde_derive v1.0.19
   Compiling flame v0.2.0 (file:///builddir/build/BUILD/flame-0.2.0)
     Running `/usr/bin/rustc --crate-name flame src/lib.rs --emit=dep-info,link -C opt-level=3 --test --cfg 'feature="default"' --cfg 'feature="json"' --cfg 'feature="serde"' --cfg 'feature="serde_derive"' --cfg 'feature="serde_json"' -C metadata=28b36c5823936b04 -C extra-filename=-28b36c5823936b04 --out-dir /builddir/build/BUILD/flame-0.2.0/target/release/deps -L dependency=/builddir/build/BUILD/flame-0.2.0/target/release/deps --extern thread_id=/builddir/build/BUILD/flame-0.2.0/target/release/deps/libthread_id-eb8f395d40bc418b.rlib --extern serde=/builddir/build/BUILD/flame-0.2.0/target/release/deps/libserde-10db73606eeef041.rlib --extern serde_json=/builddir/build/BUILD/flame-0.2.0/target/release/deps/libserde_json-326d713b5ff9f963.rlib --extern lazy_static=/builddir/build/BUILD/flame-0.2.0/target/release/deps/liblazy_static-b8a8a5c94cf262f4.rlib --extern serde_derive=/builddir/build/BUILD/flame-0.2.0/target/release/deps/libserde_derive-7ac2cd764e990b08.so -Copt-level=3 -Cdebuginfo=2 -Clink-arg=-Wl,-z,relro,-z,now`
     Running `/usr/bin/rustc --crate-name demo examples/demo.rs --crate-type bin --emit=dep-info,link -C opt-level=3 --cfg 'feature="default"' --cfg 'feature="json"' --cfg 'feature="serde"' --cfg 'feature="serde_derive"' --cfg 'feature="serde_json"' -C metadata=a20dc1259beb3faf -C extra-filename=-a20dc1259beb3faf --out-dir /builddir/build/BUILD/flame-0.2.0/target/release/examples -L dependency=/builddir/build/BUILD/flame-0.2.0/target/release/deps --extern thread_id=/builddir/build/BUILD/flame-0.2.0/target/release/deps/libthread_id-eb8f395d40bc418b.rlib --extern serde=/builddir/build/BUILD/flame-0.2.0/target/release/deps/libserde-10db73606eeef041.rlib --extern serde_json=/builddir/build/BUILD/flame-0.2.0/target/release/deps/libserde_json-326d713b5ff9f963.rlib --extern lazy_static=/builddir/build/BUILD/flame-0.2.0/target/release/deps/liblazy_static-b8a8a5c94cf262f4.rlib --extern serde_derive=/builddir/build/BUILD/flame-0.2.0/target/release/deps/libserde_derive-7ac2cd764e990b08.so --extern flame=/builddir/build/BUILD/flame-0.2.0/target/release/deps/libflame-64c51b792d8f85f6.rlib -Copt-level=3 -Cdebuginfo=2 -Clink-arg=-Wl,-z,relro,-z,now`
     Running `/usr/bin/rustc --crate-name tests tests/tests.rs --emit=dep-info,link -C opt-level=3 --test --cfg 'feature="default"' --cfg 'feature="json"' --cfg 'feature="serde"' --cfg 'feature="serde_derive"' --cfg 'feature="serde_json"' -C metadata=f2f68ee89d7bcf71 -C extra-filename=-f2f68ee89d7bcf71 --out-dir /builddir/build/BUILD/flame-0.2.0/target/release/deps -L dependency=/builddir/build/BUILD/flame-0.2.0/target/release/deps --extern thread_id=/builddir/build/BUILD/flame-0.2.0/target/release/deps/libthread_id-eb8f395d40bc418b.rlib --extern serde=/builddir/build/BUILD/flame-0.2.0/target/release/deps/libserde-10db73606eeef041.rlib --extern serde_json=/builddir/build/BUILD/flame-0.2.0/target/release/deps/libserde_json-326d713b5ff9f963.rlib --extern lazy_static=/builddir/build/BUILD/flame-0.2.0/target/release/deps/liblazy_static-b8a8a5c94cf262f4.rlib --extern serde_derive=/builddir/build/BUILD/flame-0.2.0/target/release/deps/libserde_derive-7ac2cd764e990b08.so --extern flame=/builddir/build/BUILD/flame-0.2.0/target/release/deps/libflame-64c51b792d8f85f6.rlib -Copt-level=3 -Cdebuginfo=2 -Clink-arg=-Wl,-z,relro,-z,now`
    Finished release [optimized] target(s) in 16.51 secs
     Running `/builddir/build/BUILD/flame-0.2.0/target/release/deps/flame-28b36c5823936b04`
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out
     Running `/builddir/build/BUILD/flame-0.2.0/target/release/deps/tests-f2f68ee89d7bcf71`
running 11 tests
test end_with ... ok
test implicit_guarded_event ... ok
test multiple_guard_early_return ... ok
test named_guarded_event ... ok
test single_event ... ok
test single_nested ... ok
test double_nested ... ok
test dropped_guarded_event ... ok
test threads ... FAILED
test cant_note ... ok
test wrong_name ... ok
failures:
---- threads stdout ----
    thread 'threads' panicked at 'assertion failed: `(left == right)`
  left: `1`,
 right: `6`', tests/tests.rs:111:4
failures:
    threads
test result: FAILED. 10 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out
TyOverby commented 6 years ago

-j 1 not -j1

ignatenkobrain commented 6 years ago

@TyOverby I really don't know difference. In short options you don't have to put whitespace between option and argument... But anyway, https://kojipkgs.fedoraproject.org//work/tasks/4751/23094751/build.log

+ /usr/bin/cargo test --release -j 1
       Fresh serde v1.0.20
       Fresh num-traits v0.1.40
       Fresh itoa v0.3.4
       Fresh lazy_static v0.2.9
       Fresh unicode-xid v0.1.0
       Fresh libc v0.2.33
       Fresh quote v0.3.15
       Fresh dtoa v0.4.2
       Fresh synom v0.11.3
       Fresh thread-id v3.2.0
       Fresh serde_json v1.0.6
       Fresh syn v0.11.11
       Fresh serde_derive_internals v0.17.0
       Fresh serde_derive v1.0.20
   Compiling flame v0.2.0 (file:///builddir/build/BUILD/flame-0.2.0)
     Running `/usr/bin/rustc --crate-name flame src/lib.rs --emit=dep-info,link -C opt-level=3 --test --cfg 'feature="default"' --cfg 'feature="json"' --cfg 'feature="serde"' --cfg 'feature="serde_derive"' --cfg 'feature="serde_json"' -C metadata=c9e4e4a3f349e4ae -C extra-filename=-c9e4e4a3f349e4ae --out-dir /builddir/build/BUILD/flame-0.2.0/target/release/deps -L dependency=/builddir/build/BUILD/flame-0.2.0/target/release/deps --extern serde=/builddir/build/BUILD/flame-0.2.0/target/release/deps/libserde-ec017728d018bd3d.rlib --extern thread_id=/builddir/build/BUILD/flame-0.2.0/target/release/deps/libthread_id-4985de65cb0942b0.rlib --extern serde_derive=/builddir/build/BUILD/flame-0.2.0/target/release/deps/libserde_derive-167d4c4f590db4c6.so --extern lazy_static=/builddir/build/BUILD/flame-0.2.0/target/release/deps/liblazy_static-914213a2ef2edf6b.rlib --extern serde_json=/builddir/build/BUILD/flame-0.2.0/target/release/deps/libserde_json-e482f776da45e78b.rlib -Copt-level=3 -Cdebuginfo=2 -Clink-arg=-Wl,-z,relro,-z,now`
     Running `/usr/bin/rustc --crate-name demo examples/demo.rs --crate-type bin --emit=dep-info,link -C opt-level=3 --cfg 'feature="default"' --cfg 'feature="json"' --cfg 'feature="serde"' --cfg 'feature="serde_derive"' --cfg 'feature="serde_json"' -C metadata=4d6e2734eeea7cab -C extra-filename=-4d6e2734eeea7cab --out-dir /builddir/build/BUILD/flame-0.2.0/target/release/examples -L dependency=/builddir/build/BUILD/flame-0.2.0/target/release/deps --extern serde=/builddir/build/BUILD/flame-0.2.0/target/release/deps/libserde-ec017728d018bd3d.rlib --extern thread_id=/builddir/build/BUILD/flame-0.2.0/target/release/deps/libthread_id-4985de65cb0942b0.rlib --extern serde_derive=/builddir/build/BUILD/flame-0.2.0/target/release/deps/libserde_derive-167d4c4f590db4c6.so --extern lazy_static=/builddir/build/BUILD/flame-0.2.0/target/release/deps/liblazy_static-914213a2ef2edf6b.rlib --extern serde_json=/builddir/build/BUILD/flame-0.2.0/target/release/deps/libserde_json-e482f776da45e78b.rlib --extern flame=/builddir/build/BUILD/flame-0.2.0/target/release/deps/libflame-0ce628a2675805c5.rlib -Copt-level=3 -Cdebuginfo=2 -Clink-arg=-Wl,-z,relro,-z,now`
     Running `/usr/bin/rustc --crate-name tests tests/tests.rs --emit=dep-info,link -C opt-level=3 --test --cfg 'feature="default"' --cfg 'feature="json"' --cfg 'feature="serde"' --cfg 'feature="serde_derive"' --cfg 'feature="serde_json"' -C metadata=211e7079543cb1f9 -C extra-filename=-211e7079543cb1f9 --out-dir /builddir/build/BUILD/flame-0.2.0/target/release/deps -L dependency=/builddir/build/BUILD/flame-0.2.0/target/release/deps --extern serde=/builddir/build/BUILD/flame-0.2.0/target/release/deps/libserde-ec017728d018bd3d.rlib --extern thread_id=/builddir/build/BUILD/flame-0.2.0/target/release/deps/libthread_id-4985de65cb0942b0.rlib --extern serde_derive=/builddir/build/BUILD/flame-0.2.0/target/release/deps/libserde_derive-167d4c4f590db4c6.so --extern lazy_static=/builddir/build/BUILD/flame-0.2.0/target/release/deps/liblazy_static-914213a2ef2edf6b.rlib --extern serde_json=/builddir/build/BUILD/flame-0.2.0/target/release/deps/libserde_json-e482f776da45e78b.rlib --extern flame=/builddir/build/BUILD/flame-0.2.0/target/release/deps/libflame-0ce628a2675805c5.rlib -Copt-level=3 -Cdebuginfo=2 -Clink-arg=-Wl,-z,relro,-z,now`
    Finished release [optimized] target(s) in 5.63 secs
     Running `/builddir/build/BUILD/flame-0.2.0/target/release/deps/flame-c9e4e4a3f349e4ae`
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out
     Running `/builddir/build/BUILD/flame-0.2.0/target/release/deps/tests-211e7079543cb1f9`
running 11 tests
test double_nested ... ok
test dropped_guarded_event ... ok
test end_with ... ok
test cant_note ... ok
test implicit_guarded_event ... ok
test multiple_guard_early_return ... ok
test named_guarded_event ... ok
test single_event ... ok
test single_nested ... ok
test wrong_name ... ok
test threads ... FAILED
failures:
---- threads stdout ----
    thread 'threads' panicked at 'assertion failed: `(left == right)`
  left: `5`,
 right: `6`', tests/tests.rs:111:4
failures:
    threads
test result: FAILED. 10 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out
TyOverby commented 6 years ago

well, that's because I'm an idiot.

It's not cargo test -j its cargo test -- --test-threads=1

ignatenkobrain commented 6 years ago

@TyOverby thanks for help, now it passes ;)