Fix android string - Githubissues

llohse / libnpy

C++ library for reading and writing of numpy's .npy files

MIT License

361 stars 72 forks source link

Fix android string #2

Closed lsc1234582 closed 6 years ago

lsc1234582 commented 7 years ago

Use custom to_string because it is not available in the standard library in some Android toolchains.
Fix std::string initialization from char array by explicitly specifying the string length (to avoid including null terminator, which might happen with some compilers).

llohse commented 7 years ago

Thank you! I will look into this tomorrow.

llohse commented 7 years ago

Thanks again for bringing this up and proving a patch. I rewrote it a little bit to simplify the overall code. Should be fixed with d92bcbcb7c247e0b0ccaeb653298caf6b58f6fc3.

Can you please confirm?