search

llohse / libnpy

C++ library for reading and writing of numpy's .npy files
MIT License
361 stars 72 forks source link

Add support for stream interface #34

Closed FreddieLiardet closed 1 year ago

FreddieLiardet commented 1 year ago

Add ability to:

llohse commented 1 year ago

Thank you for this PR. I will look into it later this week.

FreddieLiardet commented 1 year ago

Hello, is there any update for this?

llohse commented 1 year ago

Since I am working on a new C++ API (see #31) -- which is long overdue -- it does not really make sense to merge this just now. My plan is to adapt the new API to expose streams but I did not find the time yet to properly test it. I will try to make the changes later today and prepare a new release.

llohse commented 1 year ago

Thank you for your patience. Could you take a look into #31 if the API defined in the branch object-interface works for you? If you prefer to keep using the old C-style API, we could integrate the stream interface into it, too, but I was planning to drop it eventually.

FreddieLiardet commented 1 year ago

I've had a look at the new api, it will work for our needs. Closing the pull request as no longer needed. Do you have an eta of when #31 will be merged?

llohse commented 1 year ago

Thanks for the feedback. I will merge it and prepare a new release later this week.