Add accept-multiclient to default arguments

lloiser / go-debug

🐛 A go debugger for atom using delve.

https://atom.io/packages/go-debug

MIT License

388 stars 21 forks source link

Add accept-multiclient to default arguments #156

Closed michaelgugino closed 4 years ago

michaelgugino commented 4 years ago

This allows connecting to dlv server to run arbitrary commands while dlv is running.

lloiser commented 4 years ago

Hi, sorry for the late response. I'm not using atom or go-debug anymore... As far as I remember using this flag can cause some issues because go-debug does not know that commands on the server have been executed. So the internal state in go-debug potentially gets messed up... What happens in go-debug after running some commands on the server? If I'm right I would not add this by default but only via a configuration setting.

michaelgugino commented 4 years ago

@lloiser yeah, seems everyone is switching off of atom these days, it's a shame.

When you run commands that advance the program (such as step or continue) the UI goes stale in atom, but you can return to atom and press step and everything will be back up to date. I think it's a small trade off and most users will never know the difference.

lloiser commented 4 years ago

Released with v1.7.0. Thx for your contribution! :bowing_man: